Open glowmango opened 4 years ago
I've not worked with Electron before, but I am excited enough about this (Keep is one of my main go-to apps on Android for so many reasons!) that I hope to tinker and see if I can solve this issue. I imagine it's a common theme for Electron/Cordova/etc so I think it shouldn't be too hard to track down.
Cheers on the app altogether though, @tmcinerney! If I can integrate Keep with OS X keyboard shortcuts I'll be over the moon. Yes, I am a 200-year-old hipster who uses those hep cat thoughtwords, you crazy kids, you! (actually, I just never sleep and so am deliriously firing off messages into the void, but it's six of one and half a dozen of the other, right?)
I believe this issue is still ongoing - I am not able to log in and get the same message as in the screenshot above from @glowmango.
Hey @carmensandoval I don't actually use Google Keep anymore, but I thought a dependency bump might help.
I wasn't able to reproduce the issue y'all had, but would be able to test this beta release before I merge the code and release the updated application?
FYI ^^ @glowmango
@tmcinerney tried your beta release as I'm seeing the same issue - no luck unfortunately. Same error as above.
works now - not sure what changed!
Doesn't work for me, I still get the above error on a brand new install of 2.0.0 beta
Same here!
Why am I in this thread?
On Tue, Jun 23, 2020 at 6:12 PM Carmen Sandoval notifications@github.com wrote:
Same here!
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/tmcinerney/keep/issues/11#issuecomment-648523969, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOXHQHA5ZZN66M7RTY47U53RYFHJRANCNFSM4KCGXYVA .
-- William M. Legrain
I've still not been able to replicate this. The Stack Overflow post linked above indicates an issue with the user agent.
Looking at the docs from menubar, it seems I can set the user agent for the load options, as described here.
I've updated the dependency bump PR to include the setting of the user agent.
I've built an updated version of the app and updated the beta release I linked before: https://github.com/tmcinerney/keep/releases/tag/v2.0.0beta
I tested the change using this site which displays the user agent.
I can see the following when simply setting it to Chrome
(which isn't a real user agent, and least when I look at the latest user agents as defined here).
The current version of Chrome on MacOS looks more like:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/83.0.4103.116 Safari/537.36
When navigating to the user agent test page in Keep I can see mentions of Electron and the like:
keep
from Homebrew, encountered the same issue reported here.loadUrlOptions: {userAgent: 'Chrome'}
in your main.js in the const keep = menubar([...])
bit starting on line 6 and it's working now (for me).Iunno anything about electron or javascript tho so ymmv.
Just added the useragent attribute in index.html
webview tag and it's working for me now:
Line 10: <webview autosize partition="persist:keep" src="https://keep.google.com" useragent="Mozilla/5.0 (Windows NT 6.1; WOW64; Trident/7.0; AS; rv:11.0) like Gecko">
@tmcinerney Please change the application code in main.js to const keep = menubar({ browserWindow: { alwaysOnTop: true, frame: true, height: 700, movable: true, resizable: true, width: 500 }, icon: path.join(__dirname, 'assets', 'IconTemplate.png'), index: 'https://keep.google.com', preloadWindow: true, showDockIcon: true, showOnAllWorkspaces: true, tooltip: 'Keep' }); keep.setOption('loadUrlOptions',{userAgent: 'Chrome'})
And rebuild the app.
Everything should work now. I have changed 'frame' option to true for ease in movability of application.
If anyone wants to
If anyone want then this is the app with changes written above: https://drive.google.com/file/d/1CJs2r15TC_6RnGDyLEfIW3eoOebh1mr8/view?usp=sharing
Incredibly excited by the existence of this app. However, the app will not sign in as Google is classing it as 'insecure'.
Screenshot here: