search

tmdh / laravel-kit

A desktop Laravel admin panel app
https://tmdh.github.io/laravel-kit/
GNU General Public License v2.0
1.24k stars 136 forks source link

Show errors from tinker & fix bug #30

Closed evaleries closed 2 years ago

evaleries commented 2 years ago

This PR will fix the bug from yarn run dev:one (https://github.com/sveltejs/svelte-loader/issues/188) and (#27)

Closes #27

tmdh commented 2 years ago

Error in Linux for any input:

ErrorException with message 'fwrite(): Send of 6 bytes failed with errno=32 Broken pipe'
evaleries commented 2 years ago

This PR should normally work on Windows.

I haven't tested this yet on Linux. Maybe you can help me solve this problem?

Thanks

tmdh commented 2 years ago

The current implementation is not an optimal way to get tinker output. I pushed a new implementation to master branch. Can you please check if it works on Windows? It works on Linux.

evaleries commented 2 years ago

The current implementation is not an optimal way to get tinker output. I pushed a new implementation to master branch. Can you please check if it works on Windows? It works on Linux.

It's working fine, good job. I'll close this PR