Format JSON output - Githubissues

tmdh / laravel-kit

A desktop Laravel admin panel app

https://tmdh.github.io/laravel-kit/

GNU General Public License v2.0

1.26k stars 137 forks source link

Format JSON output #38

Closed damms005 closed 2 years ago

damms005 commented 2 years ago

This PR adds a new feature that ensures output that are JSON are nicely formatted

tmdh commented 2 years ago

Can you give me a tinker script to test?

damms005 commented 2 years ago

@tmdh please clarify what you mean by "tinker script"

The PR simply ensures that when you do something like User::all()->toJSON() or run any code that results in a JSON-like output, the output is a nicely-formatted JSON, rather than being squished together.

Refer to the before-and-after screenshots below:

BEFORE:

AFTER:

tmdh commented 2 years ago

LGTM

damms005 commented 2 years ago

@tmdh post-merge comment: can I add a voice to PR 36? It is a good addition for Linux folks. I tested it and it worked flawlessly!

luanfreitasdev commented 2 years ago

There's no way to know exactly. But I believe that many prefer to install the deb to convert it. Looking for the empty icon is not practical.