tmdh / laravel-kit

A desktop Laravel admin panel app
https://tmdh.github.io/laravel-kit/
GNU General Public License v2.0
1.24k stars 136 forks source link

New setting for command output height #48

Closed damsfx closed 1 year ago

damsfx commented 1 year ago

Does it make sense to you to have a new setting for the command output view to be maximize to the available window height?

Actual max height is very tiny on large screens due to max-h-64 class. https://github.com/tmdh/laravel-kit/blob/94c03d64c931ad767f4c90cbd5739b03554cf687/src/renderer/components/Command.vue#L29

tmdh commented 1 year ago

Would setting max-h-64 to min-h-64 help?

damsfx commented 1 year ago

Would setting max-h-64 to min-h-64 help?

One solution would be to remove max-h-64 overflow-y-auto.
The parent container is a column flexbox, the result of the command would take up the space it needs automatically.

But in this case, everything that comes before the result will no longer be fixed and will be in the scroll flow.

tmdh commented 1 year ago

Fixed by commit 6915166bc8df0863d215e960d0bcca7911e2e5a1 .