Use POH for dummyreadbuffers

tmds / Tmds.LinuxAsync

MIT License

25 stars 3 forks source link

Use POH for dummyreadbuffers #83

Closed tmds closed 4 years ago

tmds commented 4 years ago

Minor improvement. The APIs used here are new in .NET 5.

cc @antonfirsov @adamsitnik

antonfirsov commented 4 years ago

It seems it does not work yet on the server:

error CS0117: 'GC' does not contain a definition for 'AllocateUninitializedArray'

adamsitnik commented 4 years ago

@antonfirsov could you try --runtimeversion 5.0.* ? It should download the latest bits

antonfirsov commented 4 years ago

--runtimeversion 5.0.* did not help. I will ask Sebastien for support. @tmds any chance to revert this until we can make sure it works?

adamsitnik commented 4 years ago

@antonfirsov Could you please try to find the version of SDK and Runtime that has exposed GC.AllocateUninitializedArray as a public method and specifying it in an explicit way to the BenchmarkDriver?. Sth like:

--runtime 5.0.0-preview.3.20173.5 --aspnetcoreversion 5.0.0-preview.3.20173.4 --sdk 5.0.100-preview.3.20174.1

BTW --runtimeversion 5.0.* is a tip I got from @sebastienros last time I've run into similar issue ;)