search

tmds / Tmds.LinuxAsync

MIT License
25 stars 3 forks source link

Revert "Use POH for dummyreadbuffers" #85

Closed antonfirsov closed 4 years ago

antonfirsov commented 4 years ago

Temporarily reverting #83 to unblock benchmarking, should be easy to undo. I hope we can figure it out in a couple of days.

/cc @sebastienros

tmds commented 4 years ago

@davidfowl @halter73 this API is in runtime repo for 3 weeks (and 5.0 preview2). We can't figure out how to use it on the benchmark machine. Any suggestions?

cc @adamsitnik

halter73 commented 4 years ago

Are you talking about https://github.com/dotnet/runtime/pull/33526? Sometimes it takes a while for aspnetcore to update its runtime dependency. Our internal dashboard shows we're only 3 days behind though.

You could try passing --runtimeVersion Latest to the BenchmarksDriver. That doesn't wait for our dependency update flow.

tmds commented 4 years ago

Our internal dashboard shows we're only 3 days behind though.

This is weeks behind. Are we using the same machines?

halter73 commented 4 years ago

Are you passing --runtimeVersion Latest to the BenchmarksDriver?

With that flag, the aspnet/Benchmarks infrastructure is designed to support dynamically updating to the latest dotnet runtime and sdk even if no aspnetcore runtime has been successfully built agains it yet.