search

tmds / Tmds.Systemd

.NET Core library for interacting with systemd
Other
128 stars 17 forks source link

Add journal logger options to add the full exception stack trace, with a custom formatter #46

Closed ygoe closed 3 years ago

ygoe commented 4 years ago

Fixes #45

tmds commented 3 years ago

@ygoe if you can make some time for this in coming week, I will make a release that includes this change. If you don't have time, that's fine also, and I'll make a release that doesn't include this feature yet.

ygoe commented 3 years ago

Oh, an upcoming release is a good motivation. :-) I'm a bit uncertain about the field names. I could leave it as FULL_EXCEPTION, but I might also use EXCEPTION for the full string and leave out the other fields. The difference could be determined when EXCEPTION exists but EXCEPTION_TYPE not. Whatever the field name, it needs to be provided by the JournalLoggerOptions class if we want anybody to consider it. I'll just push another commit with the changes so far.

tmds commented 3 years ago

@ygoe I hadn't noticed you already pushed a commit. I've reviewed it now.

tmds commented 3 years ago

ping @ygoe

tmds commented 3 years ago

@ygoe this is part of 0.8.0 which I've just uploaded to nuget.org.

ygoe commented 3 years ago

Thank you!