search

tmds / linux-dev-certs

55 stars 8 forks source link

Add support for Gentoo #22

Closed babaruh closed 5 months ago

tmds commented 5 months ago

@babaruh overall this looks good. ptal at my comment about FindLibrewolfCertificateStores. Did you run and verify this works on Gentoo?

Could you also leave out the white-space changes on the code that doesn't functionally change? Such changes are noise to the real diff.

babaruh commented 5 months ago

Did you run and verify this works on Gentoo?

Yes. It works.

Could you also leave out the white-space changes on the code that doesn't functionally change? Such changes are noise to the real diff.

I can, but i don't know how. Tbh I would like to make more changes in code style(add .editorconfig and so on).

tmds commented 5 months ago

Tbh I would like to make more changes in code style(add .editorconfig and so on).

A lot of maintainers (including myself) like contributions to follow the existing style and not have style changes to unrelated bits.

I haven't looked into an .editorconfig file because I'm unfamiliar with it and I don't know how it might impact contributors who are not familiar with it either (IDE/tooling not setup). I'll make some time to explore it.

tmds commented 5 months ago

@babaruh thanks a lot for adding Gentoo support!

I'll include this in a nuget.org release tomorrow.

If you want to try out the NuGet package before then, you can install it from the CI feed:

dotnet tool update -g linux-dev-certs --prerelease --add-source https://www.myget.org/F/tmds/api/v3/index.json