search

tmeasday / meteor-router

MIT License
366 stars 76 forks source link

Is IE supported from the master branch? #122

Closed lattejed closed 11 years ago

lattejed commented 11 years ago

Sorry to open an issue for a question but I thought it would be better for other people than sending an email.

Is IE support (< IE10) available in the master branch or do I have to use the ie-support branch explicitly?

I've installed router (which installed a branch of page-js) and have installed HTML5-History-API, making sure it's being included before router.

I still can't get IE 8 or 9 to work. Clicking on links works (the #/ gets added to the route and the proper template loads) but using Meteor.Router.to does not (it just falls back to the main page).

I'm not using named routes, just the url, if that makes any difference.

IE 10 seems to work ok, though I haven't tested it extensively.

lattejed commented 11 years ago

Is this project actively maintained?

lattejed commented 11 years ago

I think my question is a fairly simple one. If it's confusing in any way let me know.

tmeasday commented 11 years ago

Funnily enough I was just looking at this.

Meteor.Router.go() works fine for me in IE8. Perhaps you aren't preventDefault()-ing or something?

lattejed commented 11 years ago

No, I'm calling preventDefault().

I haven't had an opportunity to dig too deeply myself, does IE only work with named routes by chance? I don't use named routes at all in favor of just calling the path directly.

Specific to my question, do I have to use the IE branch explicitly? I would assume no but thought I would ask.

tmeasday commented 11 years ago

No, definitely not.

I was just testing with the "simple-example-app" that comes with the source. I was calling to() with paths directly.

lattejed commented 11 years ago

Ok, just tested it again in IE 8/9 and now it works. Nothing related to the router (how it's packaged, software versions, etc) has changed in the interim (except that I've added a couple of routes).

I guess I'll go ahead and close this.

Thanks for the feedback.