search

tmeasday / meteor-router

MIT License
366 stars 76 forks source link

Blaze support #142

Closed Slava closed 10 years ago

Slava commented 10 years ago

Blaze support in the simplest possible form (rerender the whole renderPage region on changes). Might be useful for legacy projects using this router instead of IronRouter.

Slava commented 10 years ago

Hmm, didn't see the latest upgrade from @Tarangp, I am sorry :)

tmeasday commented 10 years ago

Hmm.. I feel like there's stuff in here that's not in @Tarangp's commit.

I don't feel very well placed to be making these decisions seeing as I'm not using Router on any projects right now. Do one of you two want to take it over?

Slava commented 10 years ago

No, I just want my router to work :)

I didn't see the @Tarangp's commits and kept using my fork. I will take a look at master to see how different they are.

Slava commented 10 years ago

@Tarangp didn't fix the other helper (currentPage) and didn't put the reactive data context for the renderPage on Blaze. And he is relying on the UI symbol being available (which by the way could be defined by other libraries as well), where my PR relies on the release version (which is not accurate when running Meteor from the checkout).

I suggest @Tarangp takes a look at my PR and ports some changes to the master.

Tarang commented 10 years ago

@Slava Will go through this and edit the master patching in your changes.

Perhaps I should check for Packages.spark? (But this would break pre 0.6.3 apps) - I'm guessing router is used for a few older apps too?

Tarang commented 10 years ago

Done. Only change is I set it to check for Packages.ui instead in the isBlaze method and added a few checks to allow pre 0.6.3 apps to still run.