search

tmeasday / storybook-skeleton

3 stars 1 forks source link

feat: Add plugin/loader profiler #24

Open bebraw opened 3 years ago

bebraw commented 3 years ago

I added the profiler behind PROFILE_CPU=1 as it felt related.

Screenshot:

Screen Shot 2021-06-08 at 16 44 44

It's useful but not probably as useful as we expected. Thanks to composition, it was easy to plug in.

Related to #21.

tmeasday commented 3 years ago

Cool. Although it does seem to break things for me:

image

When I run without COMPILE_LAZILY=1 it does seem more helpful:

image

Already that tells us the bulk of the time is "modules with no loaders", which I assume is node_modules?

bebraw commented 3 years ago

Yeah, exactly.

I wonder if we hit some bug with the plugin.

On 9. Jun 2021, at 14.49, Tom Coleman @.***> wrote:

 Cool. Although it does seem to break things for me:

When I run without COMPILE_LAZILY=1 it does seem more helpful:

Already that tells us the bulk of the time is "modules with no loaders", which I assume is node_modules?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.