tmedwards / sugarcube-2

SugarCube is a free (gratis and libre) story format for Twine/Twee.
https://www.motoslave.net/sugarcube/2/
BSD 2-Clause "Simplified" License
177 stars 41 forks source link

.ariaDisabled(true) not affecting tabindex #219

Closed MalifaciousGames closed 1 year ago

MalifaciousGames commented 1 year ago

Is your feature request related to a problem?

Using .ariaDisabled(true) on an interactive element doesn't remove it from tab selection as it retains its tabindex='0' property.

Describe the solution you'd like.

Making disabled elements tabindex='-1' would be in line with the hover effect signifying they cannot be selected/interacted with.

tmedwards commented 1 year ago

Yeah. It should probably be doing that.

tmedwards commented 1 year ago

This is resolved, so closing the issue is okay. 👍🏻

For future reference, however, I generally close resolved issues myself either automatically by commit message or, failing that, manually.

In this case the resolves #219 bit in the titles would have triggered auto-closing upon the develop branch being merged into master.