search

tmedwards / sugarcube-2

SugarCube is a free (gratis and libre) story format for Twine/Twee.
https://www.motoslave.net/sugarcube/2/
BSD 2-Clause "Simplified" License
185 stars 42 forks source link

Changed README.md word: build.js outputs to `build` dir, not `dist` #268

Closed BawdyInkSlinger closed 1 year ago

BawdyInkSlinger commented 1 year ago

I'm proposing this change based off of my experience of following these steps.

$ node build.js 
Starting builds...

Building Twine 1.x version:
 -> assembling libraries...
 -> compiling JavaScript...
Browserslist: caniuse-lite is outdated. Please run:
  npx update-browserslist-db@latest
  Why you should do it regularly: https://github.com/browserslist/update-db#readme
 -> compiling CSS...
 -> building: "build\twine1\sugarcube-2\header.html"
 -> copying : "build\twine1\sugarcube-2\sugarcube-2.py"
 -> copying : "build\twine1\sugarcube-2\LICENSE"

Building Twine 2.x version:
 -> assembling libraries...
 -> compiling JavaScript...
 -> compiling CSS...
 -> building: "build\twine2\sugarcube-2\format.js"
 -> copying : "build\twine2\sugarcube-2\icon.svg"
 -> copying : "build\twine2\sugarcube-2\LICENSE"

Builds complete!  (check the "build" directory)

Running the script ends with this output:

(check the "build" directory)

I feel like there might be a step to output into the dist dir, but it's not node build.js.

tmedwards commented 1 year ago

PRs should be to the develop branch only, never to master. The only thing committed to master are releases.