tmedwards / sugarcube-2

SugarCube is a free (gratis and libre) story format for Twine/Twee.
https://www.motoslave.net/sugarcube/2/
BSD 2-Clause "Simplified" License
177 stars 41 forks source link

Upgrade jQuery to the latest version (3.7.1) #269

Closed BawdyInkSlinger closed 10 months ago

BawdyInkSlinger commented 1 year ago

Is your feature request related to a problem? This is a list of the changes:

Describe the solution you'd like. Download https://code.jquery.com/jquery-3.7.1.min.js and overwrite the existing jquery.min.js contents

Additional context. The line const $dataInitPassages = $elems.find('[data-init-passage]'); (found in engine.js) throws an error on jquery 3.6.4 if you run the code in Node with JSDOM. It runs as expected in 3.7.1.

I doubt anyone else would find this relevant, but other bug fixes and performance improvements are likely in the upgrade.

tmedwards commented 1 year ago

The develop branch is currently using jQuery v3.7.0. I can update that further, but maybe try that branch first.

BawdyInkSlinger commented 1 year ago

Oops. Done.

tmedwards commented 11 months ago

Resolved by 9a817e983f0e52d8306d78d204dc5be9de2cde5d

tmedwards commented 11 months ago

Forgot about your PR. Mea culpa.

At least it's done. 😅

BawdyInkSlinger commented 10 months ago

NP, thanks!