tmeiczin / opendcp

Created digital cinemas packages (DCP)
http://www.opendcp.org
GNU General Public License v3.0
122 stars 52 forks source link

CPL XMl Write, title length limitation #294

Open akayueh opened 7 years ago

akayueh commented 7 years ago

Hi

I noticed in the code the title is hardcoded to 80 characters, if a title is longer than 80, an overflow will cause the filename to be appended with the timestamp which is the next data field in the class, can we please increase this or use the flex vector array in C++

typedef struct { char uuid[40]; char annotation[128]; char size[18]; char digest[40]; int duration; int entry_point; char issuer[80]; char creator[80]; char title[80]; char timestamp[30]; char kind[32]; char rating[32]; char filename[MAX_FILENAME_LENGTH]; int reel_count; reel_t reel[MAX_REELS]; } cpl_t;

Example:

Desired Title: TheGreatWallMandarinLanguageVersion_RTG_F_EN-XX_AU-M_XX_2K_XX_20170113_ABC_SMPTE_OV

Results: TheGreatWallMandarinLanguageVersion_RTG_F_EN-XX_AU-M_XX_2K_XX_20170113_ABC_SMPTE2017-01-16T02:59:21+00:00

tmeiczin commented 7 years ago

Thanks.