search

tmenier / AsyncPoco

A long-"awaited" fully asynchronous PetaPoco fork
Other
127 stars 33 forks source link

Added IsolationLevel optional parameter to GetTransactionAsync and Begin... #21

Open pavick opened 9 years ago

pavick commented 9 years ago

...TransactionAsync

The default isolation level is read committed.

tmenier commented 9 years ago

Sorry about the delay. I've not seen it documented that ReadCommitted is the default isolation level for any db other that SQL Server, so I'm not sure I agree with the implementation. I'm on board with the idea but I think it needs to defer to the provider for the default rather than hard-coding to ReadCommitted.

pavick commented 9 years ago

I understand. In that case the easiest thing to do would be to overload the Transaction methods with methods that have a required IsolationLevel parameter.

tmenier commented 8 years ago

Sorry for dropping the ball on this. If it's still something you're interested in I'm willing to accept this and make a few tweaks so as not to assume ReadCommitted is the default. Let me know.