search

tmenier / AsyncPoco

A long-"awaited" fully asynchronous PetaPoco fork
Other
127 stars 33 forks source link

ExistsAsync(object poco) #24

Closed coderasm closed 8 years ago

coderasm commented 9 years ago

I am working on a small project and am using generics in such a way, I would like to test for the existence of a record through a poco and not through a key directly. A portion of my implementation below, shows what I am needing. I went ahead and implemented the Task<bool> ExistsAsync(object poco) into asyncpoco. Have a look at this merge request and decide if you want to incorporate it. Petapoco horribly violates the DRY principle. I may take it upon myself to refactor portions of the code to get rid of all the duplication.

public async Task<bool> Exists(T poco) {
     return await database.ExistsAsync(poco)
}

It takes into account autoincrementing pocos. I created a customized exception to warn about autoincrement pocos not possibly existing. I also included tests for the new behavior in PetaTest and they are passing.

coderasm commented 9 years ago

Sorry about not having a separate branch. As you can see several more commits were pushed for a fix to UpdateAsync(poco, columns).

tmenier commented 8 years ago

Sorry for letting this go unacknowledged. I'd be happy to discuss your objectives (if this is still something you want), but your changes are quite large and far reaching. There are many, many additions and changes beyond just ExistsAsync. Maybe this should be multiple, smaller PRs?

coderasm commented 8 years ago

I no longer work on a project was using AsyncPoco. Pulling these changes into master is no longer necessary. Thank you for getting back to me.

On Fri, Aug 12, 2016 at 12:51 PM, Todd Menier notifications@github.com wrote:

Closed #24 https://github.com/tmenier/AsyncPoco/pull/24.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tmenier/AsyncPoco/pull/24#event-754450160, or mute the thread https://github.com/notifications/unsubscribe-auth/AAbPvGnM2SJNeQm9093vVB--FgqPZ_zuks5qfM7AgaJpZM4Eg6H9 .