search

tmenier / AsyncPoco

A long-"awaited" fully asynchronous PetaPoco fork
Other
127 stars 33 forks source link

Converts AsyncPoco.Tests project to use NUnit testing framework #33

Closed LeeGrissom closed 7 years ago

LeeGrissom commented 7 years ago

The previous code used a proprietary PetaTest.cs library to execute all of the tests. By switching to NUnit, we can retain all of the existing code, but enjoy a more flexible testing framework. I've also included support for NUnitLite so that we can continue running it from a CLI, but we can also run and debug one or more tests from within Visual Studio.

I had originally tried to convert the code to xUnit, but I found it to be very difficult to get the tests working reliably. There is a lot of extra code that needs to be written to achieve the same kinds of testing that we can achieve for free with NUnit.

Other changes:

Visual Studio defaults to 4 spaces indentation when you install, but I tried to remember to switch to Tabs for this project. Let me know if I accidentally messed something up.

tmenier commented 7 years ago

Sorry for the delay, been spending pretty much all my available OSS time on another project these days. These changes sound fine me. PetaTest never bugged me but did make me wonder why one would write their own testing framework from scratch :). But I like NUnit and for me the big advantage is I can run 1 test at a time if I want to.

I'll get this reviewed/merged soon. Conceptually I'm good with all of it.

LeeGrissom commented 7 years ago

No worries Todd. I too have been super busy with other things. Don't hesitate to suggest modifications, I'm very easy going with that. Yeah, I wanted to be able to debug individual tests using the nice integration of NUnit with Visual Studio, Resharper, etc. I will try to resume AsyncPoco later this week. --Lee

On Mon, Aug 7, 2017 at 5:44 AM, Todd Menier notifications@github.com wrote:

Sorry for the delay, been spending pretty much all my available OSS time on another project these days. These changes sound fine me. PetaTest never bugged me but did make me wonder why one would write their own testing framework from scratch :). But I like NUnit and for me the big advantage is I can run 1 test at a time if I want to.

I'll get this reviewed/merged soon. Conceptually I'm good with all of it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tmenier/AsyncPoco/pull/33#issuecomment-320653347, or mute the thread https://github.com/notifications/unsubscribe-auth/AAtBADjpYEb5W9s7izWDH2XRQBYjvZekks5sVwalgaJpZM4OgEq3 .