search

tmerr / i3ipc-rs

A Rust library for controlling i3-wm through its IPC interface
MIT License
106 stars 33 forks source link

Add missing WorkspaceChange enum variants #10

Closed tmerr closed 7 years ago

tmerr commented 7 years ago

@soumya92 reported he was getting errors on an event workspace:reload

It looks like it has actually been around for a while but it was accidentally left undocumented until recently: https://github.com/i3/i3/pull/2656 . We should add these cases to our WorkspaceChange enum, and probably "move" as well, which is also undocumented but hopefully not for long https://github.com/i3/i3/pull/2847 .

Add the WorkspaceChangeEnum variants Rename, Reload, Restored, Move.

soumya92 commented 7 years ago

Looks like @wawe already fixed this in https://github.com/wawe/i3ipc-rs/commit/94586c2015247afac11aaf115953bcdbd3a86486

tmerr commented 7 years ago

I left a comment on his commit to see if he wants wants to create the PR https://github.com/wawe/i3ipc-rs/commit/94586c2015247afac11aaf115953bcdbd3a86486

tmerr commented 7 years ago

Went ahead and merged #12