Forward compatibility: Replace unreachable!() with Unknown enums

tmerr / i3ipc-rs

A Rust library for controlling i3-wm through its IPC interface

MIT License

107 stars 33 forks source link

Forward compatibility: Replace unreachable!() with Unknown enums #11

Closed soumya92 closed 7 years ago

soumya92 commented 7 years ago

Fixes https://github.com/tmerr/i3ipc-rs/issues/8, and should make the library forward compatible. Also adds a note on compatibility in README, including the logging facility used by the library.

Edit: does not update the version number

tmerr commented 7 years ago

I'm not entirely sure how github's review workflow is supposed to work, but you can probably git commit --amend the branch, force push, and the changes will be reflected in the pull request

soumya92 commented 7 years ago

Fine by me. Done!