search

tmerr / i3ipc-rs

A Rust library for controlling i3-wm through its IPC interface
MIT License
106 stars 33 forks source link

Add marks property to Node #45

Open sophacles opened 5 years ago

sophacles commented 5 years ago

When a node has marks set, they will be in a 'marks' key in the JSON node. The key is absent if no marks are set. This isn't documented in the i3-rpc manual, so it's not stable. At the same time i3 changes fairly slowly, so it could be worth adding.

tmerr commented 4 years ago

Hi, I'd prefer to honor https://i3wm.org/docs/ipc.html#_tree_reply

While the nodes might have more properties, please do not use any properties which are not documented here. They are not yet finalized and will probably change!

If the property's useful, it's probably best to request i3 devs stabilize it first

sophacles commented 4 years ago

Rebased against latest master

sophacles commented 4 years ago

I also noticed this was documented recently in i3-next: https://github.com/i3/i3/commit/7427d61f7f742b7de25d0b196ed5e6684f97af6f#diff-1429183bc39fbbc846a64ce95be90b0b

It's not on the published site yet, but presumably it will be soon.

6A61736F6E206E61646572 commented 4 years ago

We can safely merge this as it has been confirmed stable by Airblader as well as the relevant PR being merged.

Thanks! We don't aim to provide all fields there (this is mentioned in the paragraph above, too), but marks are definitely stable and worth documenting, so thanks again!

N-Parsons commented 4 years ago

@tmerr, with the stability confirmation given above, can this now be merged?