tmerr / i3ipc-rs

A Rust library for controlling i3-wm through its IPC interface
MIT License
107 stars 33 forks source link

Implement WindowChange::Mark #6

Closed bennyandresen closed 7 years ago

bennyandresen commented 7 years ago

Sorry if my pull request wasn't as clear, I'm new to debugging Rust.

Marks showing up in the ipc json payload where introduced with i3 version 4.13 and it breaks i3ipc-rs.

Best regards and happy holidays, Benny

tmerr commented 7 years ago

Thank you for this!

The only reason I haven't merged your changes yet is that I want to work out the right way to handle versioning first: see issues #8 and #9.

Cheers, Trevor

tmerr commented 7 years ago

8 half fixes this by logging a warning instead of hitting an unreachable