tmesser / DeckManager

BSD 3-Clause "New" or "Revised" License
5 stars 2 forks source link

Drawing (and multi-drawing) crisis cards doesn't check that there's a game running #32

Open MaxPeck opened 9 years ago

MaxPeck commented 9 years ago

1) Start the program 2) Try to draw a crisis card without actually starting a game 3) System.ArgumentNullException: Value cannot be null. Parameter name: source at System.Linq.Enumerable.Last[TSource](IEnumerable`1 source) at DeckManagerOutput.GameWindow.DrawCrisisToolStripMenuItemClick(Object sender, EventArgs e) at System.Windows.Forms.ToolStripItem.RaiseEvent(Object key, EventArgs e) at System.Windows.Forms.ToolStripMenuItem.OnClick(EventArgs e) at System.Windows.Forms.ToolStripItem.HandleClick(EventArgs e) at System.Windows.Forms.ToolStripItem.HandleMouseUp(MouseEventArgs e) at System.Windows.Forms.ToolStripItem.FireEventInteractive(EventArgs e, ToolStripItemEventType met) at System.Windows.Forms.ToolStripItem.FireEvent(EventArgs e, ToolStripItemEventType met) at System.Windows.Forms.ToolStrip.OnMouseUp(MouseEventArgs mea) at System.Windows.Forms.ToolStripDropDown.OnMouseUp(MouseEventArgs mea) at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks) at System.Windows.Forms.Control.WndProc(Message& m) at System.Windows.Forms.ScrollableControl.WndProc(Message& m) at System.Windows.Forms.ToolStrip.WndProc(Message& m) at System.Windows.Forms.ToolStripDropDown.WndProc(Message& m) at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m) at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m) at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

tmesser commented 9 years ago

There are an absolute swarm of these sorts of bugs. Not having a game loaded and attempting to do pretty much anything that checks or modifies the game's current state will absolutely crash the program. I noticed this a few months back and decided it was too low impact for me to care about them, but if you want to fix them I will accept the hell out of those pull requests.