tmesser / DeckManager

BSD 3-Clause "New" or "Revised" License
5 stars 2 forks source link

Title handling #41

Open MaxPeck opened 9 years ago

MaxPeck commented 9 years ago

We need to be able to:

I want to be able to:

tmesser commented 9 years ago

A lot of this walks the really thin line that DM has to tread with being helpful but not being too smart I'm fine with having the default line of succession as a reference, but implementing the succession line is likely a waste of time, since it would require coding distinctions between ranks (President can stay President while brigged, but Admiral can't), and mandate us being aware of which character is which, which is not something we really give that much of a crap about right now. We could probably do this best by simply adding PresidentRank and AdmiralRank to each character's JSON and polling it from there, but even then that's a lot of extra rules to codify for something that frequently gets houseruled in some way or another.

We definitely need to be able to set and retrieve titles, and we definitely need to be able to pass cards wholesale from one player to another (which shouldn't be hard), but changing displays and fiddling around with succession laws seems pretty overwrought, at least at this phase of the project's development.

clanpotshake commented 9 years ago

There's already a method written to pass cards between players, but I don't think it's used anywhere. Looking at it I'm not even sure it's correct, but check out GiveCardToPlayer in GameManager.cs

MaxPeck commented 9 years ago

Yeah, I wouldn't even imagine using the line of succession automatically at any point other than the start of the game, at any point in the project really. Maybe reminding to change it if a titled player reveals, but even then I don't want to sort out who's eligible and who's not.

MaxPeck commented 9 years ago

There's already a method written to pass cards between players, but I don't think it's used anywhere. Looking at it I'm not even sure it's correct, but check out GiveCardToPlayer in GameManager.cs

It's used to implement Adama's OPG, it looks like. See, uh, https://github.com/tmesser/DeckManager/blob/0a32f89d9a979762f534051f217d4ac189985ec7/DeckManagerOutput/GameWindow.cs#L615 . I haven't poked it to verify it works, but I suspect it does, so it'd just need to be accessible from the manage player UI.