search

tmewett / BrogueCE

Brogue: Community Edition - a community-lead fork of the much-loved minimalist roguelike game
https://sites.google.com/site/broguegame/
GNU Affero General Public License v3.0
1.02k stars 108 forks source link

Pick up maintaining and distributing the iOS version #258

Closed tmewett closed 2 years ago

tmewett commented 3 years ago

sandoze is no longer distributing the version they ported to iOS; see this thread.

To just get the current version back up, I think we only need someone with a developer account to build and publish it.

weo3dev commented 3 years ago

I think I could help out on this - is it mainly just keeping an Apple dev account open and active, (which I think is just $99/year) or would there be more involved? If I can just set it / forget it, I'm pretty sure I could fill this gap for a year or so.

tmewett commented 3 years ago

Hi weo3dev, thanks very much for the offer. Uploading the current version would be better than nothing - however it is quite out-of-date (CE 1.8.1 vs 1.9.3) and so wouldn't be valid for the weekend contests or anything.

Would it be possible to publish any changes to the port that other people might make in future? That would be ideal!

riccjohn commented 3 years ago

I'm happy to open a developer account and can help with getting changes merged and redeployed as long as you don't mind me asking a bunch of questions @tmewett . I'm a dev, but have never done any C dev, so it'd be hard for me to spot check any incoming PR's.

To be clear, we'd need to fork @sethhoward 's iBrogueCE and ideally update it to the latest version of BrogueCE, and then deploy to the app store, right? I don't see a license on the iBrogueCE repo, so hopefully forking it and deploying it to the app store is ok.

I'm not sure if this is allowed by the license, but I'm sure if someone set up a Patreon, there would be enough donations during the year to cover the app store cost.

sethhoward commented 3 years ago

I think the bigger issue is I’m in control of the application distribution using the name Brogue and BrogueCE. There’s also a few other hoops that need to be jumped through during release that have already been taken care of from my end.

Updating the code base is fairly trivial as I’ve done it a dozen or so times. Obviously anyone who wanted to contribute to QoL of the iPad version would be appreciated. The bigger issue is I no longer want to pay for the developer program on a free application. I don’t mind volunteering my time keeping things up to date or dealing with the release process. If we want to get 100 people to donate $1 I would be happy to renew and do another release.

pender commented 3 years ago

@sethhoward I'll send you $100, it's no problem. Can I send it with Google Wallet? Let me know which of your gmail accounts I should use, or shoot me an email at penderprime@gmail.com if it's easier.

HomebrewHomunculus commented 3 years ago

Looks like people on Reddit are discussing the iOS version again - shall I let them know that it's being looked at, or?

https://old.reddit.com/r/roguelikes/comments/n2dc4j/best_roguelikes_on_ios_that_dont_feel_to_clunky/gwiqqlm/

tmewett commented 3 years ago

This is still open - no word yet from sethhoward - so if someone else wants to pick it up, please say. Thanks

riccjohn commented 3 years ago

@pender Were you able to get into contact with Seth?

@tmewett Unless I was misunderstanding previously, I think none of us can actually upload it to the app store with the current name and some other things.

I think the bigger issue is I’m in control of the application distribution using the name Brogue and BrogueCE. There’s also a few other hoops that need to be jumped through during release that have already been taken care of from my end.

pender commented 3 years ago

@pender Were you able to get into contact with Seth?

No, I sent a couple of emails but didn't hear back. I'd be happy to fund $100 of Apple tax for someone else who can resurrect the app.

AndrewSav commented 3 years ago

@pender from that reddit post it sounds like you used to maintain iOS version in the past, is that right? If yes, what were the main challenges that made you stop, if money is not the issue, may I ask?

pender commented 3 years ago

@pender from that reddit post it sounds like you used to maintain iOS version in the past, is that right? If yes, what were the main challenges that made you stop, if money is not the issue, may I ask?

No, I never published an iOS app.

sluedecke commented 3 years ago

I think the bigger issue is I’m in control of the application distribution using the name Brogue and BrogueCE. There’s also a few other hoops that need to be jumped through during release that have already been taken care of from my end.

Is it an option to transfer these to another entity? E.g. the developer account of someone else?

I do maintain one for my small business and would offer to use it for a brogue distribution.

AndrewSav commented 3 years ago

@sluedecke as mentioned above the current owner has not responded to the emails, so whether it is an option or not sounds moot.

sluedecke commented 3 years ago

@AndrewSav: you are right. Still I wanted to ask it once more since another month has passed :)

I would love to have brogue-ce on my iPad as well, is it an option for the developers to have it published under a modified name e.g. "Brogue Community Edition"?

sethhoward commented 3 years ago

If someone would like to PR into the CE iPad edition I will help test it and publish to the App Store. At this point I’d prefer to release after the new iOS version so we can catch any new OS issues.

AndrewSav commented 3 years ago

Thank you @sethhoward. @sluedecke Is this something you would look at? I had a look and there has been substantial changes to the BrogueCE code base, and Seth's repo was done by copying the code base and making modifications on top, so what needs to be done, that this process is to be repeated with the new codebase. Since I have zero experience with programming for iPad I did not feel I'm suitable for the task. I was hoping that the fork was done by including the main sources and may be a few particular diffs on top of it, which I could re-apply, but that was not the case.

With some patience it still should be possible to diff the fork with the 1.8 base and then see how to apply on top of the current, but I felt I do not have enough mac/iPad/Swift expertise for that.

sethhoward commented 3 years ago

I would just do a diff between CE and iPad. Only touch the C files.

I do have some hooks in the C files but they should be clearly commented.

tmewett commented 3 years ago

Thanks very much Seth - we really appreciate it! I have opened sethhoward/iBrogueCE#1 to track the updating of the app to the latest version; that discussion can continue there.

For here, I think it makes sense to ask @sethhoward if there are ways we can transfer some more work from your shoulders? Up to you:

apollovy commented 3 years ago

Hey there! I'm the person that is currently maintaining CDDA port for iOS. I've made a build from https://github.com/sethhoward/Brogue-iPad and installed it on my iPhone and iPad, and it's doing great. I would be happy to patron this project first by publishing to the App Store, and then by updating the codebase, if it's simple copy-paste, and if it's so and the sources from the original BrogueCE are not being touched at all, then I'll change the approach to use the original BrogueCE as a submodule not to deal with copy-pasting again ever, if it's possible.

About the app names. I'll just choose something like "BrogueCE RPG" and this will be enough for the app store to give me a green light.

Another questing that I have is: what are the differences between https://github.com/sethhoward/Brogue-iPad and https://github.com/sethhoward/iBrogueCE ?

I'm planning to do this the next week, anyone against that? As the first step I think it'll be enough to at least have a working but outdated game in the app store, so everyone could start playing. And then we can move further.

Correct me if there are discussions that I'm missing.

sethhoward commented 3 years ago

I believe we’re waiting for the current port of BrogueCE to be updated for iOS. The current branch has gone stale with some build errors.

The difference between the two.. one is community edition and the other is the original brogue.

Sent from my iPhone excuse my spelling

On Oct 3, 2021, at 10:43 AM, Yuri Apollov @.***> wrote:

 Hey there! I'm the person that is currently maintaining CDDA port for iOS. I've made a build from https://github.com/sethhoward/Brogue-iPad and installed it on my iPhone and iPad, and it's doing great. I would be happy to patron this project first by publishing to the App Store, and then by updating the codebase, if it's simple copy-paste, and if it's so and the sources from the original BrogueCE are not being touched at all, then I'll change the approach to use the original BrogueCE as a submodule not to deal with copy-pasting again ever, if it's possible.

About the app names. I'll just choose something like "BrogueCE RPG" and this will be enough for the app store to give me a green light.

Another questing that I have is: what are the differences between https://github.com/sethhoward/Brogue-iPad and https://github.com/sethhoward/iBrogueCE ?

I'm planning to do this the next week, anyone against that? As the first step I think it'll be enough to at least have a working but outdated game in the app store, so everyone could start playing. And then we can move further.

Correct me if there are discussions that I'm missing.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

apollovy commented 3 years ago

I've checked out master branches of both apps and built'em both without touching a thing. Are you talking about some branches with updates?

I'm building on MBP 2019 running macOS Big Sur 11.5.1.

sethhoward commented 3 years ago

With the latest updates

Sent from my iPhone excuse my spelling

On Oct 3, 2021, at 11:48 AM, Yuri Apollov @.***> wrote:

 I've checked out master branches of both apps and built'em both without touching a thing. Are you talking about some branches with updates?

I'm building on MBP 2019 running macOS Big Sur 11.5.1.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

AndrewSav commented 3 years ago

@apollovy the ipad port repo has a copy of the entire brogues source code modified so that it could be compiled for iPad. Seth is saying that the modifications are minimal, but I was not able to establish that first hand by comparing the source code.

tmewett commented 3 years ago

@apollovy a WIP update branch is referenced in the linked ticket above: sethhoward/iBrogueCE#1. As I understand it, publishing to the App Store is no longer an obstacle. I think @sluedecke may have got stuck - perhaps you or someone could continue from where they got to?

Seeing as the discussion is ongoing on this, I can recommend joining the CE development Discord server to anyone who wants a more direct line of contact with me or the other contributors.

sethhoward commented 3 years ago

This is correct. Releasing isn’t an issue. I only need to upload a new binary when we have a copy of BrogueCE that can compile with the latest changes.

Sent from my iPhone excuse my spelling

On Oct 3, 2021, at 3:01 PM, Tom @.***> wrote:

 @apollovy a WIP update branch is referenced in the linked ticket above: sethhoward/iBrogueCE#1. As I understand it, publishing to the App Store is no longer an obstacle. I think @sluedecke may have got stuck - perhaps you or someone could continue from where they got to?

Seeing as the discussion is ongoing on this, I can recommend joining the CE development Discord server to anyone who wants a more direct line of contact with me or the other contributors.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

tmewett commented 2 years ago

Looks like @btaylor84 published it themselves, so we are back in business - thank you all for your help! Again, I invite anyone wanting to keep up with or help iOS maintenance to join the dev Discord linked in my comment above, or start any follow-up discussions in this thread.

sluedecke commented 2 years ago

Looks like @btaylor84 published it themselves, so we are back in business - thank you all for your help!

I am happy to see the efforts finally paying off! Especially since some of my initially fruitless work has made its way into the final iPad version. YAY!

btaylor84 commented 2 years ago

I stood on the shoulders of giants.