tmewett / BrogueCE

Brogue: Community Edition - a community-lead fork of the much-loved minimalist roguelike game
https://sites.google.com/site/broguegame/
GNU Affero General Public License v3.0
993 stars 107 forks source link

Player can hit an adjacent submerged monster with a staff or wand #653

Closed zenzombie closed 5 months ago

zenzombie commented 8 months ago

Fixes #578

zenzombie commented 8 months ago

I wonder if we should just make any zaps valid in this case, instead of only adjacent? is that OP?

I wondered about that as well. I do think it would be a bit OP. You could step underwater and polymorph a kraken on the other side of a lake. It's not super clear that you can't do that now, so hopefully this change makes it clearer.

One idea is to rework underwater visibility so that the player can only see a certain distance. Then allow zapping anything that can be seen. It would make deep water scarier. Could even have different kinds of water... clear, murky, etc.

zenzombie commented 5 months ago

I have another idea here that I think is simpler. The current behavior is that submerged creatures are not targetable with staffs, wands, or thrown items, regardless of whether the player is submerged or not. We could just change kraken behavior (or really any monster that submerges and can grab) such that if it grabs a player and the player knows the monster's location (player is submerged or player is telepathic), the monster will immediately surface on that same turn. This way we can avoid changing any targeting rules.

Edit: Submitted #681 as an alternative fix. It only allows targeting if the player can see the monster they are being seized by (e.g. player is submerged). Telepathy doesn't help.

tmewett commented 5 months ago

Closed in favour of 681