search

tmewett / BrogueCE

Brogue: Community Edition - a community-lead fork of the much-loved minimalist roguelike game
https://sites.google.com/site/broguegame/
GNU Affero General Public License v3.0
993 stars 107 forks source link

Replaced hitList with const hitList #697

Closed mattiarmston closed 3 months ago

mattiarmston commented 3 months ago

I have replaced every creature **hitList with const creature **hitList. This removes the incompatible const pointer errors with GCC 14 and allows for compilation without the -Wno-error=incompatible-pointer-types flag. However it introduces many strncpy and strncat warnings so I am not sure if this is an appropriate solution.

Refs #696

Any advice would be appreciated.

tmewett commented 3 months ago

However it introduces many strncpy and strncat warnings

I guess that's from the removal of the flags, not from the new consts? We had a lot of string warnings before too, so don't worry if so.

I think this fix makes sense - maybe we'll end up removing all the consts later, since clearly they are more complicated than i thought with double pointers.. Thanks for the PR!