Build CI for windows pack game to the archive 2 times

tmewett / BrogueCE

Brogue: Community Edition - a community-lead fork of the much-loved minimalist roguelike game

https://sites.google.com/site/broguegame/

GNU Affero General Public License v3.0

1.03k stars 109 forks source link

Open Cjkjvfnby opened 2 weeks ago

Cjkjvfnby commented 2 weeks ago

The first time in this line workflows/build.yml

     7z a BrogueCE-windows-x86_64.zip BrogueCE-windows

The second time during upload in step: "Upload artifact", see documentation: https://github.com/actions/upload-artifact?tab=readme-ov-file#zip-archives

Removing the line with 7z will solve the issue.

tmewett commented 1 week ago

This is intended for the macOS and Linux artifacts as GitHub zip packing doesn't preserve enough file metadata

I guess it's not required for Windows so can be changed