search

tmhglnd / mercury

A minimal and human-readable language and environment for the live coding of algorithmic electronic music.
http://www.timohoogland.com/mercury-livecoding
GNU General Public License v3.0
291 stars 13 forks source link

fix line ending: on my windows machine it fails on \r #89

Closed ajayveeage closed 1 year ago

ajayveeage commented 1 year ago

I must be the only guy in the world playing around with your project on a windows system :)..

running 'npm run test' fails on every line...

I expect this nearly parser can provide lines without the trailing \r, if so that would be the better way of fixing it... I wouldn't know where to start finding that solution, so here is my fix...

cheers.

tmhglnd commented 1 year ago

Hi, thanks for looking at this! This is much appreciated. But I just wanted to make sure I understand what you are trying to do currently. Because this parser.js in the grammar folder is actually not used in the Max version, it was a work-in-progress that I kind of abondoned in this project. The file that is actually used to parse the code when using the Max8 version is mercury.js under mercury_ide/code. If you like to check the newest mercury parser (the one that is also used in the mercury-playground) please have a look at this repository and npm package: https://github.com/tmhglnd/mercury-lang. I still am planning on including the mercury-lang in the Max version as well. But this is for the future since I haven't really updated the Max version that much anymore. The focus is mostly on the web version currently because it is easier to get started with.

ajayveeage commented 1 year ago

Yeah, i just bumped onto that other repo.. I found no direct link on https://github.com/tmhglnd, that's probably why.. Will check that repo and see if it works on win..