tmijs / tmi.js

💬 Javascript library for the Twitch Messaging Interface. (Twitch.tv)
https://tmijs.com
MIT License
1.54k stars 217 forks source link

client: secure now defaults to true (fixes #394) #405

Closed FoseFx closed 4 years ago

FoseFx commented 4 years ago

@Meerkov proposed this change in #395 but that PR went stale I changed the commit message as requested

Closes #395 Fixes #394

FoseFx commented 4 years ago

@AlcaDesign change made

Meerkov commented 4 years ago

Doesn't that mean that if you set the port to 443, it would default to insecure again?

Users should have to go out of their way to turn off security.

FoseFx commented 4 years ago

Connect() will set secure to true when the port is 443

https://github.com/tmijs/tmi.js/blob/df228dc818dbfe203bf85d19c54e7be1e6177077/lib/client.js#L1061-L1063