search

tmilovanov / wisecreator

Utility for adding word wise information to non amazon books
317 stars 52 forks source link

ASIN Handling #12

Open Ephemerality opened 5 years ago

Ephemerality commented 5 years ago

If a book already contains an ASIN (processed with Calibre or had an Amazon one injected manually), there's no need to convert it again to generate one. The script should check for the presence of one first and only do the conversion if it's missing. The conversion also changes the markup which causes location issues with X-Ray files generated for the original mobi.

Tikotik commented 5 years ago

I have no location offset problem from .mobi original file to .mobi conversion in this program, and I also have no problem when .mobi file has ASIN and ebook-convert is bypassed in this program. but I do get offset problem when I convert non-mobi files to mobi and then run this, instead of direct mobi file. I think there is some thing I am not doing right in calibre conversion that causes this.

Ephemerality commented 5 years ago

The location issue I ran into was due to having the original book on my device but using the DB from the converted book, but that's just a symptom I think.
The main problem for this issue is that there is no reason to convert the book if it already has an ASIN, right now it always converts.
With x-ray builder there was a problem where AZW3 files need an offset added, but if we're talking mobis only, that shouldn't matter (and would probably need to be created as a separate issue).

fmoraldo-mithraw commented 4 years ago

Is that what makes it loses their covers ?