tmiranda1962 / tmiranda

Automatically exported from code.google.com/p/tmiranda
2 stars 1 forks source link

Dynamic Skip Times: Rewind times should always be considered negative values #22

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
When I setup rewind times for titles, if I enter a positive value for rewind 
times it actually ends up fast forwarding by that amount.  Rewind times should 
always be rewind values, whether they're negative or positive values.  Or it 
should only fast forward if the value is negative.  If I say, "I want to rewind 
-15 seconds" I take that to mean FF 15 seconds.

To avoid breaking current users who have specified negative values for REW 
times, I propose applying the following function to all set values for custom 
REW:

newVal = -1 * abs(currentVal)

This way newVal is always negative so if users use a negative value for REW 
times then they get a rewind and if you use a positive value (as I did) you 
still get a negative value for the REW.  On an extender it is difficult to 
enter a negative number, which is really why I think positive number for REW 
should still always skip backwards the set number of seconds.

Original issue reported on code.google.com by de...@battams.ca on 23 Dec 2011 at 5:44