tmiw / ezDV

A FreeDV device based on the ESP32.
89 stars 4 forks source link

Change underlying mode for FreeDV LSB to DIGL #46

Closed amcdermond closed 1 month ago

amcdermond commented 1 month ago

The underlying mode should be DIGL for LSB similar to how it is DIGU for USB. This will disable any audio processing including CESSB and TX equalization that could corrupt the waveform.


Before merging:

tmiw commented 1 month ago

Thanks for the change! DIGL seems to work here. However, I did notice something with the filters that I'm not sure is related. Here's what I did:

  1. Set slice A to FDVL and restart SmartSDR. The filter looks as expected:

Screenshot 2024-05-28 at 8 17 09 PM

  1. Switch slice A to FDVU, then back to FDVL. SmartSDR still shows the filter as though it's in FDVU:

Screenshot 2024-05-28 at 8 17 19 PM

TX does still look like it's behaving properly in FDVL, though, in that it's transmitting the signal below the dial frequency.

Anyway, if that filter thing is a known issue I can go ahead and merge.

tmiw commented 1 month ago

Actually, I think that filter thing might be an ezDV bug. I'll go ahead and merge this since it otherwise seems to be working okay.

amcdermond commented 1 month ago

Thanks Mooneer. I was going to try to take a look at things quickly on Sunday when I got back from SeaPac. Let me know if I can be of further assistance. There are at least three people at Flex testing these out. I’ve been monitoring 20m pretty regularly when I’m sitting at my desk.

— Annaliese McDermond, J.D. NH6Z She/Her/Hers Senior DevOps Engineer FlexRadio Systems @.***

On Fri, May 31, 2024 at 1:07 AM Mooneer Salem @.***> wrote:

Merged #46 https://github.com/tmiw/ezDV/pull/46 into main.

— Reply to this email directly, view it on GitHub https://github.com/tmiw/ezDV/pull/46#event-12996433699, or unsubscribe https://github.com/notifications/unsubscribe-auth/APZTILTK3FU73T322SBPNVTZFAVUNAVCNFSM6AAAAABINOLJ52VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSHE4TMNBTGM3DSOI . You are receiving this because you authored the thread.Message ID: @.***>

tmiw commented 1 month ago

No worries and thanks for the PR!