search

tmiyamon / acts-as-taggable-array-on

A simple and high performance tagging gem for Rails using PostgreSQL array.
MIT License
125 stars 26 forks source link

Features/rails5 ready #10

Closed bunnymatic closed 7 years ago

bunnymatic commented 7 years ago

Rails 5 seemed to be returning arrays from the .uniq calls so moving to a postgres distinct kept that return as a relation.

Cheers

auscaster commented 7 years ago

It would be great to get this merged in, I imagine there are many people using Rails 5 that want to use this.

auscaster commented 7 years ago

Looks like the CI ruby version needs to be updated to get tests passing.

bunnymatic commented 7 years ago

I was just about to put this PR in a more permanent branch and noticed the latest master (version 0.4.0) has changes that may fix this for rails 5. This may not need to be merged in as it may have been solved by d21cdd71bc54895c30f350ebd37da9afbdd9645d.

For rails5 support, you might try that version and see if it works.

auscaster commented 7 years ago

Thanks, I noticed that myself and can confirm its working :)

On 7 July 2017 at 04:25, Mr Rogers notifications@github.com wrote:

I was just about to put this PR in a more permanent branch and noticed the latest master (version 0.4.0) has changes that may fix this for rails 5. This may not need to be merged in as it may have been solved by d21cdd7 https://github.com/tmiyamon/acts-as-taggable-array-on/commit/d21cdd71bc54895c30f350ebd37da9afbdd9645d .

For rails5 support, you might try that version and see if it works.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/tmiyamon/acts-as-taggable-array-on/pull/10#issuecomment-313570155, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGKDNqKtCxn37J3urunu8ES7S6LiKi2ks5sLZcrgaJpZM4NSDA5 .

bunnymatic commented 7 years ago

As noted above, someone else's merge has solved the rails 5 issues.

Closing