Reorder README; Inline examples

tmiyamon / acts-as-taggable-array-on

A simple and high performance tagging gem for Rails using PostgreSQL array.

MIT License

125 stars 26 forks source link

Reorder README; Inline examples #31

Closed vfonic closed 4 years ago

vfonic commented 4 years ago

Hey @tmiyamon!

Thanks for the great gem! Just what I was looking for! 🤘

I found the README.md easy to read, but I thought I could add some improvements. Eventually, I made too many changes. :)

Feel free to reject this PR. I don't find the original README not clear. :D But of course I think I improved it.

You can preview my changes here: https://github.com/tmiyamon/acts-as-taggable-array-on/blob/f20f147582f8f7c25dd04d42bbeeb2101323123b/README.md

skatkov commented 4 years ago

Privet, @tmiyamon is a busy. But I'm here to help out.

There are small issues I see with this change (strictly style), but since in overall it does look like a positive improvement -- I'll just merge it.

vfonic commented 4 years ago

Thanks! Spasibo!

What would be the issue with style? I did make some style improvements to make the code more consistent (using " always, instead of ' and " mixed).

I just noticed I use the new hash syntax. I can make it into hash rocket syntax or change hash rocket syntax to new hash syntax. Which one do you prefer?

Anything else?