Adds possibility to define allowed values for tags

tmiyamon / acts-as-taggable-array-on

A simple and high performance tagging gem for Rails using PostgreSQL array.

MIT License

125 stars 26 forks source link

Adds possibility to define allowed values for tags #40

Open jplethier opened 2 years ago

jplethier commented 2 years ago

Proposal

This PR proposes to have a easy way to add simple validations for tags allowed to model using this gem

Changes

Adds an allowed option as parameters for acts_as_taggable_array_on to define allowed values for tags
Adds a validation method when the allowed param is present and is valid to ensure that all tags values are allowed
Adds a check to ensure that the allowed param is an array when it is present, raising an error if it is not an array

skatkov commented 2 years ago

Thanks for your contribution.

Can you please rebase your changes and update README accordingly?

jplethier commented 2 years ago

@skatkov I've just updated the branch with all new changes and updated readme adding information about allow list option. Please review the readme and give me any feedback if it can be more clear on better in any other way

jplethier commented 2 years ago

@skatkov thanks a lot for all the feedback and suggestions. I did some of them already, and I am in doubt about the others ones, that I answered you here.

jplethier commented 2 years ago

Nice work so far. I don't have too much time to contribute to open source these days.

So while kid is sleeping, decided to give this PR a review. If we're planning to change API of this gem, i'd love to polish it up more!

I've shared some of my thoughts on proposed changes. Some of those thoughts are pretty blury :P

I know the feeling, I have two kids, and most of work on open source or personal projects is done before they awake or after they go to bed. :D

Thanks a lot for the review and the suggestions.

jplethier commented 1 year ago

@skatkov were you able to take a look in the changes that I did after your suggestions?