tmjo / charger-card

A lovelace card for electrical vehicle (EV) home chargers and charging robots.
MIT License
90 stars 59 forks source link

en-GB Translation #52

Closed codeclinic closed 1 year ago

codeclinic commented 1 year ago

Just saw this changelog on the latest release:

Fix en-GB translation that was always present but not working (as opposed to regular en).

en-GB by virtue of being the original English (from England) literally is "regular en" and therefore all other "English" varieties are the deviants and not vice-versa.

tmjo commented 1 year ago

Don't disagree with you there, but for some reason en-GB exists in HA?

image

I just saw this difference because I had one environment setup with "English" and another in "English (GB)" in HA where the latter did not translate at all. If I remember correctly, before HA got support for specifying time format (24h) and number format separately, I think the advice was to choose GB, so I think that's why I put my device to English GB. My native language is Norwegian, but I prefer to have all my devices in English language even though I can't stand imperial units and AM/PM for time. Me about that. :)

My en.json and en-GB.json files are the same though, feel free to correct the English though :)

Cheers!

purcell-lab commented 1 year ago

I have proposed some very minor changes for en_GB. https://github.com/tmjo/charger-card/pull/53

Myself I use en_AU, which has en_GB spelling, but uses the metric system and supports 24 hour time.

tmjo commented 1 year ago

Jolly good, thanks!

tmjo commented 1 year ago

Really sorry for the delay, but finally it is updated in v0.2.7