search

tmk / tmk_core

TMK keyboard library
161 stars 59 forks source link

Enable warnings as errors #13

Closed fredizzimo closed 8 years ago

fredizzimo commented 8 years ago

Enables warnings as errors as described in this issue https://github.com/tmk/tmk_keyboard/issues/340 I also fixed all warnings that I could find, including this one https://github.com/tmk/tmk_keyboard/issues/317.

I found a way to use the preprocessor to make a generic fix for https://github.com/tmk/tmk_keyboard/issues/317. The solution is quite complex, and is a combination of these techniques. http://stackoverflow.com/a/31470425 http://stackoverflow.com/a/11742317

tmk commented 8 years ago

Interesting. It looks really fun I'll learn those macro tricks. But it may be too complex for solution as you said.

Thanks always!

tmk commented 8 years ago

Could you make separate PR only for "Remove warning when mousekeys are disabled"? I want to mege this earlier.

fredizzimo commented 8 years ago

I have created separate pull requests now