search

tmk / tmk_core

TMK keyboard library
161 stars 59 forks source link

Chibios is no longer a submodule #6

Open fredizzimo opened 8 years ago

fredizzimo commented 8 years ago

Hi,

I was going to merge the new updates to the infinity_ergodox project. However I got the first problem immediately when trying to compile the master branch.

The tmk_core repository no longer contains the Chibios source code as a subrepository, so the project won't compile directly. Are we supposed to download the correct version of Chibios ourselves in order to make it work? I think it was quite handy to have it as a submodule, and therefore always the correct version.

fredizzimo commented 8 years ago

Note that the serial uart support for ergodox will need at least this commit from flabbergast's chibios branch. https://github.com/flabbergast/ChibiOS/commit/fc6686e84486a6afedde9ad394e344b8025e8c07

tmk commented 8 years ago

yes, adding submodule is good idea I'll use 'kinetis' branch.

tmk commented 8 years ago

hmm, submodule doesn't work when subtree-ing tmk_core. I'll leave this alone for a while until I get nice idea.

fredizzimo commented 8 years ago

I created a pull request https://github.com/tmk/tmk_core/pull/8, with one possible solution to the problem. I believe this is the best we can do without resorting to custom git plugins, or scripts for updating the submoudules.