search

tmk / tmk_keyboard

Keyboard firmwares for Atmel AVR and Cortex-M
3.99k stars 1.71k forks source link

unneeded delay in momentary layer switch #201

Closed tmk closed 9 years ago

tmk commented 9 years ago

Press Fn(Layer switch momentary) then a key on the layer immediately, you will see delay before appearing the key on terminal.

EDIT: The delay is obvious when keeping the key preessed to get key repeating. For example, users keep 'Fn + ;' pressed down on HHKB keymap to get left arrow repeating. Meanwhile, if the key is released immediately it registered when released and the delay is not obvious.

The delay seems to be related to TAPPING_TERM.

Probably tapping code has a bug.

https://geekhack.org/index.php?topic=56494.msg1715297#msg1715297

boblehest commented 9 years ago

Hey, I noticed the delay as well some time ago (My LEDs indicate the active layer, so the delay was very apparent), and today it hit me what was causing the delay. It's the tapping delay, as you said, so the issue isn't with the tapping mechanism, but the fact that it's being used wrongly. :p

The fix is rather simple, change this define (in common/action_code.h):

#define ACTION_LAYER_MOMENTARY(layer)    ACTION_LAYER_ON_OFF(layer)

into:

#define ACTION_LAYER_MOMENTARY(layer)    ACTION_LAYER_INVERT(layer, ON_BOTH)
tmk commented 9 years ago

Nice.

And this gaves me a clue of where the problem root was.

Fixed at 1f4a22ee81ec1986d1ca190c78c66231d37b50e2.