search

tmk / tmk_keyboard

Keyboard firmwares for Atmel AVR and Cortex-M
3.99k stars 1.71k forks source link

TIMER_DIFF* bugfix #646

Closed purdeaandrei closed 4 years ago

purdeaandrei commented 4 years ago

Hello, Please see the two individual commit messages for explanation of the changes.

tmk commented 4 years ago

Thanks for posting this elaborate bugfix and comments. I'll look into it and merge later.

As for files under tmk_core including this file, I have a plan to change license to more permissive one like modified BSD or Apache from current GPL. Let me know if you mind this license change in the future.

purdeaandrei commented 4 years ago

As for files under tmk_core including this file, I have a plan to change license to more permissive one like modified BSD or Apache from current GPL. Let me know if you mind this license change in the future.

I don't mind, you can change the license.

Please also note that I submitted the same bugfix to QMK as well: https://github.com/qmk/qmk_firmware/pull/8585 Their PR is a bit larger, because they used TIMER_DIFF wrong in a few places.