search

tml1024 / FluffyDisplay

FluffyDisplay: Manage virtual displays on your Mac
Apache License 2.0
325 stars 42 forks source link

[Feature Request] Custom Resolutions #5

Open WeeJeWel opened 2 years ago

WeeJeWel commented 2 years ago

Thank you for this great piece of software!

I would like to be able to enter a custom resolution (width x height x ppi).

Cueball commented 2 years ago

Yeah it's missing quite a few historically common resolutions; adding to or editing the list of resolutions would be invaluable.

I was looking for 1680x1050 (WSXGA+) - this was the resolution for 20" Cinema Display and 20" iMac (mid 2007 aka iMac7,1).

tml1024 commented 2 years ago

I was looking for 1680x1050 (WSXGA+) - this was the resolution for 20" Cinema Display and 20" iMac (mid 2007 aka iMac7,1).

Adding that is so trivial that I feel I can just ask you to submit a patch;)

Cueball commented 2 years ago

Patch done: https://github.com/tml1024/FluffyDisplay/pull/7 Hadn't looked to see how easy it was, so thanks for the tip :-)

But that doesn't eliminate the need to either add a custom resolution, or ability to edit the list of resolutions. Creating a PR, waiting for merge and release - sure, it gets the job done eventually, but efficient? :-/

Suggestion: maybe if there was something like a resolutions.txt file that was read on startup? Put the file in App Support; create a default file if it doesn't exist or isn't a correctly parseable list of resolutions. [Instead of hard-coding the list of resolutions to support, the default list is bundled as an asset and copied to App Support if there's a problem reading the file there.]

tml1024 commented 2 years ago

I will create a new release within some days. Not sure when I will have time and interest to add custom resolutions. Would it be enough if one could add custom resolutions using a configuration file or something like that? Handling that would be easier than coding a UI just for it.

Cueball commented 2 years ago

add custom resolutions using a configuration file

Sure, that's what I was trying to propose (obviously not well!) with the "resolutions.txt" (or "resolutions.conf" or whatever) idea. Any user can simply define new resolutions by editing an existing text-based config file. [If the file doesn't exist, a default config file (included in the app bundle) is copied to the expected location. This should also happen if the config file is unreadable for some reason.]

No additional UI required, except maybe a UI option to "Reset config file to default values". Most (if not all) people wanting to use this app aren't going to be shy of editing a config file.

tml1024 commented 2 years ago

Ah sorry, I read something and forget it immediately, it seems. Will implement this perhaps next weekend.

mmm117 commented 2 years ago

It would be better if end user can enter custom resolution directly. Thanks!!