search

tmm1 / http_parser.rb

simple callback-based HTTP request/response parser
MIT License
200 stars 43 forks source link

joyent/http-parser update version #36

Closed tlewin closed 6 years ago

tlewin commented 10 years ago

I was making some tests with the source code and I observed that the joyent/http-parser was tied in the 1.0 version and the current version is the 2.3.

The problem is that the joyent/http-parser repository's HEAD was detached (# HEAD detached at 62110ef) and the extconf.rb tries to update the code from the git repository.

To fix it, I just removed the repository and added it again:

git submodule deinit ext/ruby_http_parser/vendor/http-parser
git rm ext/ruby_http_parser/vendor/http-parser
git submodule add https://github.com/joyent/http-parser.git ext/ruby_http_parser/vendor/http-parser

I ran the tests and everything worked fine, except the "HTTP::Parser should parse request: line folding in header value" item, but it is a little bit controversial, since the current http-parser version keeps the \t in the header value and the old version remove s it.