Native extension: include ruby/debug.h for rb_postponed_job_register_one prototype

tmm1 / rbtrace

like strace, but for ruby code

MIT License

1.71k stars 65 forks source link

Native extension: include ruby/debug.h for rb_postponed_job_register_one prototype #82

Closed georgeclaghorn closed 4 years ago

georgeclaghorn commented 4 years ago

Avoids relying on the implicit declaration. Fixes compiling with latest Clang from Xcode 12. Closes #81.

tmm1 commented 4 years ago

Thanks for tracking this down. It would be good to understand which ruby version added this header in case we need to do something for backwards compatibility

tmm1 commented 4 years ago

Looks like it's been there all along: https://github.com/ruby/ruby/commits/master/include/ruby/debug.h

Amazing we got by without a header this entire time.

yosiat commented 4 years ago

is it possible to release a version with this fix?

SamSaffron commented 4 years ago

Sure just pushed 0.4.14

On Mon, Aug 3, 2020 at 8:35 PM Yosi Attias notifications@github.com wrote:

is it possible to release a version with this fix?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/tmm1/rbtrace/pull/82#issuecomment-667948070, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAABIXOQTBQUWYDTRSSMEETR62HHVANCNFSM4OSNWGOQ .

yosiat commented 4 years ago

@SamSaffron thanks!