search

tmm1 / stackprof

a sampling call-stack profiler for ruby 2.2+
MIT License
2.08k stars 128 forks source link

Add marker metadata feature #215

Open tenderlove opened 1 year ago

tenderlove commented 1 year ago

We'd like to be able to log metadata along with profiles, for example "a request to X controller and Y action is starting now". I think this can be accomplished via "markers" that are available in Gecko profiles.

This is related to https://github.com/tmm1/stackprof/pull/203 and https://github.com/tmm1/stackprof/issues/194

dalehamel commented 1 year ago

along with the gecko marker support, it would be nice to take advantage of gecko's concept of "threads" to model ruby thread or fiber IDs / names. I had implemented such support in #203, which this issue now supersedes. I was reading this value each time a sample was captured though, and I don't think it quite makes sense to model this as a "marker" per se, but that might depend on the implementation you have in mind.