search

tmo1 / sms-ie

SMS Import / Export is a simple Android app that imports and exports SMS and MMS messages, call logs, and contacts from and to JSON / NDJSON files.
GNU General Public License v3.0
319 stars 38 forks source link

Add monochrome icon #132

Closed Biswa96 closed 9 months ago

Biswa96 commented 9 months ago

Fixes https://github.com/tmo1/sms-ie/issues/114

Biswa96 commented 9 months ago

The new monochrome icon is based on previous colored icon created by @Donnnno . I have just traced it in Inkscape and followed the steps from official documentation https://developer.android.com/develop/ui/views/launch/icon_design_adaptive

tmo1 commented 9 months ago

Thank you!

I tested this on an AVD (Pixel 7, Android 34), and I found that the system still displayed the regular color icon, and not the new monochrome one, until I added the <monochrome android:drawable="@drawable/ic_launcher_monochrome"/> line to app/src/main/res/mipmap-anydpi-v26/ic_launcher_round.xml in addition to app/src/main/res/mipmap-anydpi-v26/ic_launcher.xml. Please verify and fix as appropriate.

Biswa96 commented 9 months ago

Yeah, you are right. I missed the round icon. Though round icon is not required for this kind of normal drawing. Round icon is used "only if you require a different icon asset for circular masks—for example, if your branding relies on a circular shape."^1

tmo1 commented 9 months ago

Yeah, you are right. I missed the round icon. Though round icon is not required for this kind of normal drawing. Round icon is used "only if you require a different icon asset for circular masks—for example, if your branding relies on a circular shape."

Yes, I saw that. The round icon may not be required in our case, and I'm not sure why @Donnnno added it, but I guess that once it's there, it needs to have the monochrome tag included.

Donnnno commented 9 months ago

I have no idea anymore either!

tmo1 commented 9 months ago

Thank you! Merged, and credited in CONTRIBUTING.md