Fix missing sms system prompt

tmo1 / sms-ie

SMS Import / Export is a simple Android app that imports and exports SMS and MMS messages, call logs, and contacts from and to JSON / NDJSON files.

GNU General Public License v3.0

312 stars 38 forks source link

Fix missing sms system prompt #168

Closed andr5w closed 4 months ago

andr5w commented 4 months ago

Fixes an issue where the system dialog for selecting a default SMS application did not appear on some android systems when a user taps "Import Messages".

andr5w commented 4 months ago

This should fix #167.

tmo1 commented 4 months ago

Thank you! I should have added the <uses-feature> element a while ago, since Android Studio was urging it.

Regarding the exported value for .ComposeSmsActivity, for some reason the official documentation doesn't include the exported attribute at all, so I suppose that when I added it, I went with false, but I see that Fossify has true.

Did you test these two changes separately to see which one fixes the problem?

andr5w commented 4 months ago

No worries. Setting the exported value for .ComposeSmsActivity to true fixes the linked issue. I added <uses-feature> for the same reason you mentioned - it's not required for this fix (I did test this) but I figured it'd be a good inclusion from a maintenance perspective.