search

tmontaigu / CloudCompare-PythonRuntime

Python plugin for CloudCompare
55 stars 15 forks source link

Added a missing argument of convertToCloud #79

Closed Loris-L closed 1 year ago

Loris-L commented 1 year ago

I added the missing argument present in ccRasterGrid header but not in ccRasterGrid.cpp that cause an error when python plugin is compiled with CloudCompare (see #78).

tmontaigu commented 1 year ago

This is probably due to the fact that you compile against the master branch of CloudComapre while we are pinned to an older commits, so the CI is probably going to fail, and will have to change the commit hash used

Loris-L commented 1 year ago

So, will we have to wait that source code is updated to updated CloudCompare master branch?

tmontaigu commented 1 year ago

No, its that in the CI of this repo we pin the cloudcompare version used to a specific commit for which we know it works

So when making changes that make the come compile with a newer CC commit, the commit hash used in the repo needs to be updated also

I've done it on your branch

Loris-L commented 1 year ago

Ok, now it's clear. Thanks for the explanation