tmontaigu / shapefile-rs

Rust library to read & write shapefiles
MIT License
59 stars 19 forks source link

Adds method shapes_count to the readers #24

Closed Maximkaaa closed 3 years ago

Maximkaaa commented 3 years ago

Hi, @tmontaigu. Please, consider adding shapes_count() method to the shapefile reader.

This method works the same way the other methods that require existing index (like seek or read at index). If the index file is not present, Error::MissingIndexFile is returned.

Maximkaaa commented 3 years ago

Thanks for the review. I've changed all the points according to the comments.

tmontaigu commented 3 years ago

Thanks.

The PR appears as closed but in reality it is merged, I juste rebased to squash the 2 commits together, but I must have fail something else for Github not to understand that