search

tmoreno / open-log-viewer

A multi-platform log viewer built with Electron and styled with Material Design
GNU General Public License v3.0
311 stars 47 forks source link

Add copy command to copy texts from log file #14

Closed gstvomacedo closed 3 years ago

gstvomacedo commented 4 years ago

You can now copy texts from log file by pressing keyboard shortcut.

tmoreno commented 4 years ago

Hi Gustavo!

I've just reviewed your pull request and I've found some mistakes:

  1. I've run the app on Windows 10 and I haven't be able to copy the selected text using the new menu option. Maybe that works on Linux or Mac.
  2. The menu option should be in the File menu instead of Help menu, look: Sin título

Thanks for your contribution.

gstvomacedo commented 4 years ago

Hi Gustavo!

I've just reviewed your pull request and I've found some mistakes:

  1. I've run the app on Windows 10 and I haven't be able to copy the selected text using the new menu option. Maybe that works on Linux or Mac.
  2. The menu option should be in the File menu instead of Help menu, look:
Sin título

Thanks for your contribution.

Hi, I added menu Edit with "copy" and "select all" submenu items.